Messages in this thread Patch in this message |  | | Date | Thu, 13 Feb 2014 10:32:45 -0800 | Subject | Re: ip_set: protocol %u message -- useful? | From | Cong Wang <> |
| |
On Thu, Feb 13, 2014 at 2:30 AM, Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> wrote: > On Thu, 13 Feb 2014, Ilia Mirkin wrote: >> messages in my dmesg. This might be because of some local >> configuration changes I've made, or perhaps a kernel upgrade. Either >> way, it appears this message has been a pr_notice since the original >> code added it in a7b4f989a62 ("netfilter: ipset: IP set core >> support"). >> >> Does this message provide a lot of value? Or could it be made into a pr_debug? > > That's a report message on the protocol version used by the ipset > subsystem. There was (and possibly will be) multiple protocols, so it > helps to catch basic userpsace/kernelspace communication issues.
But still it doesn't deserve a pr_notice()... pr_info() should be enough.
diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index de770ec..5ea063f 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -1945,7 +1945,7 @@ ip_set_net_init(struct net *net) return -ENOMEM; inst->is_deleted = 0; rcu_assign_pointer(inst->ip_set_list, list); - pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL); + pr_info("ip_set: protocol %u\n", IPSET_PROTOCOL); return 0; }
|  |