lkml.org 
[lkml]   [2014]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 05/21] fs: Mark function as static in exofs/super.c
From
On Thu, Feb 13, 2014 at 11:28 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 02/09/2014 03:01 PM, Rashika Kheria wrote:
>> Mark function as static in exofs/super.c because it is not used outside
>> this file.
>>
>> This also eliminates the following warning in exofs/super.c:
>> fs/exofs/super.c:546:5: warning: no previous prototype for '__alloc_dev_table' [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> Hi Rashika
>
> Thanks for the fixes.
>
> Do you need me to push it to Linus through my tree or do you need an:
> ACK-by: Boaz Harrosh <bharrosh@panasas.com>
>
> [Same for [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c ]
>
> Thanks again
> Boaz
>

Hi Boaz,

It would be nice if you could push it to Linus through you tree.

Thanks,
Rashika Kheria

>> ---
>> fs/exofs/super.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
>> index 9d97633..57f59a2 100644
>> --- a/fs/exofs/super.c
>> +++ b/fs/exofs/super.c
>> @@ -543,8 +543,8 @@ static int exofs_devs_2_odi(struct exofs_dt_device_info *dt_dev,
>> return !(odi->systemid_len || odi->osdname_len);
>> }
>>
>> -int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
>> - struct exofs_dev **peds)
>> +static int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
>> + struct exofs_dev **peds)
>> {
>> struct __alloc_ore_devs_and_exofs_devs {
>> /* Twice bigger table: See exofs_init_comps() and comment at
>>
>



--
Rashika Kheria
B.Tech CSE
IIIT Hyderabad


\
 
 \ /
  Last update: 2014-02-13 20:21    [W:0.053 / U:2.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site