Messages in this thread | | | Date | Thu, 13 Feb 2014 06:01:03 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: fix two sparse warnings in early boot string handling |
| |
On 02/13/2014 02:31 AM, Matt Fleming wrote: > On Wed, 12 Feb, at 03:31:05PM, H. Peter Anvin wrote: >> >> The real answer IMO ought to be that since arch/x86/boot/string.c is now >> used separately from boot.h (eboot.c which includes efi-stub-helper.c >> does *not* include boot.h) we may have to move those string functions >> into a separate header file. >> >> Matt, do you have any opinions here? > > This makes sense to me. Perhaps arch/x86/boot/lib/string.c which would > be useable by both arch/x86/boot/*.c and arch/x86/boot/compressed/*.c? >
That would be fine, but the issue at hand isn't the .c file but the lack of a corresponding .h file...
-hpa
| |