Messages in this thread | | | Subject | Re: [PATCH v2 2/2] dp83640: Get pin and master/slave configuration from DT | From | Stefan Sørensen <> | Date | Thu, 13 Feb 2014 15:23:23 +0100 |
| |
On Tue, 2014-02-11 at 21:19 +0100, Richard Cochran wrote: > > +- dp83640,slave: If present, this phy will be slave to another dp83640 > > + on the same mdio bus. > > Wouldn't it be more natural to have one "dp83640,master" property > rather than multiple slave properties?
I wanted to keep the common case of a single phy simple, i.e. no need to specify any master/slave properties.
> Most of these pr_err lines are a bit _way_ too long for coding style.
I will fix that in the next version.
Stefan
| |