Messages in this thread |  | | Date | Thu, 13 Feb 2014 15:20:40 +0900 | Subject | Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning | From | DaeSeok Youn <> |
| |
OK. If I send a patch like this again, ChangeLog is written as you comment.
Thanks. Daeseok Youn.
2014-02-13 11:28 GMT+09:00 David Rientjes <rientjes@google.com>: > On Thu, 13 Feb 2014, Daeseok Youn wrote: > >> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001 >> From: Daeseok Youn <daeseok.youn@gmail.com> >> Date: Thu, 13 Feb 2014 10:11:39 +0900 >> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning >> >> kernel/resource.c:518:5: warning: >> symbol 'reallocate_resource' was not declared. Should it be static? >> >> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> > > Changelog would be better if it said it's only referenced in file scope so > it can be marked static. > > Acked-by: David Rientjes <rientjes@google.com>
|  |