Messages in this thread Patch in this message |  | | Date | Thu, 13 Feb 2014 12:23:17 +0000 | From | Mark Rutland <> | Subject | Re: [PATCH 1/4] phy: miphy365x: Add Device Tree bindings for the MiPHY365x |
| |
On Thu, Feb 13, 2014 at 11:03:14AM +0000, Lee Jones wrote: > > > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe > > > devices. It has 2 ports which it can use for either; both SATA, both > > > PCIe or one of each in any configuration. > > > > > > Cc: devicetree@vger.kernel.org > > > Cc: Srinivas Kandagatla <srinivas.kandagatla@st.com> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > --- > > > .../devicetree/bindings/phy/phy-miphy365x.txt | 43 ++++++++++++++++++++++ > > > 1 file changed, 43 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-miphy365x.txt b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > new file mode 100644 > > > index 0000000..fdfa7ca > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > @@ -0,0 +1,43 @@ > > > +STMicroelectronics STi MIPHY365x PHY binding > > > +============================================ > > > + > > > +This binding describes a miphy device that is used to control PHY hardware > > > +for SATA and PCIe. > > > + > > > +Required properties: > > > +- compatible: Should be "st,miphy365x-phy" > > > +- #phy-cells: Should be 2 (See example) > > The first example has #phy-cells = <1>. > > Right, will fix. Should be 2. > > > What do the cells mean? What are the expected values? > > http://www.spinics.net/lists/arm-kernel/msg307209.html
Ok. Could that be mentioned in the binding document then?
Cheers, Mark.
|  |