Messages in this thread |  | | Date | Thu, 13 Feb 2014 17:46:15 +0530 | Subject | Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators | From | Yadwinder Singh Brar <> |
| |
Hi,
On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > S2MPS11/S2MPS14 regulators support different modes of operation: > - Always off; > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > - Always on; > This is very similar to S5M8767 regulator driver which also supports > opmodes (although S5M8767 have also low-power mode). > > This patch adds parsing the operation mode from DTS by reading a > "op_mode" property from regulator child node. >
First thing since "op_mode" is not generic property, I think it should be appended with some driver specific prefix.
But IMHO its quite generic property used and required by many other PMICs(almost all used by Samsung). I would like to use this opportunity to discuss about adding it as generic regulator constraint(as initial_mode) by providing a default mapping of generic Regulator operating modes(kernel specific) to operating modes supported by hardware in regulator driver itself.
Regards, Yadwinder
|  |