lkml.org 
[lkml]   [2014]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 7/7] devicetree: bindings: Document PM8921/8058 PMICs
On 02/11, Lee Jones wrote:
>
> > +- interrupts:
> > + Usage: required
> > + Value type: <prop-encoded-array>
>
> Either provide an example or a comment to see the description of
> #interrupt-cells

It is part of the example. We also state that the format is
defined by the interrupt parent binding.

>
> > + Definition: specifies the interrupt that indicates a subdevice
> > + has generated an interrupt (summary interrupt). The
> > + format of the specifier is defined by the binding document
> > + describing the node's interrupt parent.
> > +
> > +- #interrupt-cells:
> > + Usage: required
> > + Value type : <u32>
> > + Definition: must be 2. Specifies the number of cells needed to encode
> > + an interrupt source. The 1st cell contains the interrupt
> > + number. The 2nd cell is the trigger type and level flags
> > + encoded as follows:
> > +
> > + 1 = low-to-high edge triggered
> > + 2 = high-to-low edge triggered
> > + 4 = active high level-sensitive
> > + 8 = active low level-sensitive
>
> Actually I'd prefer if you used the definitions in:
> dt-bindings/interrupt-controller/irq.h

These match the #defines in that file. I'd like to be explicit
about the numbers to prevent people from thinking they have to
use #defines and to match what other irq controllers have done
(gic, atmel-aic, etc.)

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


\
 
 \ /
  Last update: 2014-02-13 07:21    [W:0.544 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site