Messages in this thread |  | | Date | Thu, 13 Feb 2014 11:22:33 +0100 | From | Daniel Lezcano <> | Subject | Re: [PATCH V2 2/3] sched: Fix race in idle_balance() |
| |
On 02/13/2014 11:10 AM, Preeti U Murthy wrote: > Hi, > > On 02/13/2014 01:15 PM, Alex Shi wrote: >> On 02/11/2014 07:11 PM, Daniel Lezcano wrote: >>> On 02/10/2014 10:24 AM, Preeti Murthy wrote: >>>> HI Daniel, >>>> >>>> Isn't the only scenario where another cpu can put an idle task on >>>> our runqueue, >>> >>> Well, I am not sure to understand what you meant, but I assume you are >>> asking if it is possible to have a task to be pulled when we are idle, >>> right ? >>> >>> This patch fixes the race when the current cpu is *about* to enter idle >>> when calling schedule(). >> >> Preeti said the she didn't see a possible to insert a task on the cpu. >> >> I also did a quick check, maybe task come from wakeup path? > > Yes this is possible. Thanks for pointing this :) > > Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Thanks for the review !
-- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |