lkml.org 
[lkml]   [2014]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall
Hi,
On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote:

> Hi,
>
>> BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path
>> of init_inode_metadata?
>> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
>> index e095a4f..d5a2c9e 100644
>> --- a/fs/f2fs/dir.c
>> +++ b/fs/f2fs/dir.c
>> @@ -375,6 +375,7 @@ put_error:
>> /* once the failed inode becomes a bad inode, i_mode is S_IFREG */
>> truncate_inode_pages(&inode->i_data, 0);
>> truncate_blocks(inode, 0);
>> + remove_dirty_dir_inode(inode);
>> error:
>> remove_inode_page(inode);
>> return ERR_PTR(err);
> Yes, i have tested that case. Fail in init_inode_metadata has been processed correctly. Thanks.

If no other regressions, maybe you can send out the fix patch about this issue.:)

Thanks,
Gu

>




\
 
 \ /
  Last update: 2014-02-13 11:21    [W:0.073 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site