lkml.org 
[lkml]   [2014]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] kernel: panic: display reason at end + pr_emerg
On Tue, 11 Feb 2014 15:34:45 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sat, 8 Feb 2014 15:45:22 +0800 Fabian Frederick <fabf@skynet.be> wrote:
>
> > Currently, booting without initrd specified on 80x25 screen
> > gives a call trace followed by atkbd : Spurious ACK.
> > Original message ("VFS: Unable to mount root fs") is not available.
> > Of course this could happen in other situations...
> >
> > -This patch displays panic reason after call trace which could help
> > lot of people even if it's not the very last line on screen.
>
> Fair enough. Hate it when that happens!
I was sure I was not the only one :)

>
> > -Converting all panic.c printk(KERN_EMERG to pr_emerg(
>
> You missed a couple.
Thanks a lot for addition and patch fix.
What a pleasure to see such professionalism !

>
> --- a/kernel/panic.c~kernel-panicc-display-reason-at-end-pr_emerg-fix
> +++ a/kernel/panic.c
> @@ -275,8 +275,7 @@ unsigned long get_taint(void)
> void add_taint(unsigned flag, enum lockdep_ok lockdep_ok)
> {
> if (lockdep_ok == LOCKDEP_NOW_UNRELIABLE && __debug_locks_off())
> - printk(KERN_WARNING
> - "Disabling lock debugging due to kernel taint\n");
> + pr_warn("Disabling lock debugging due to kernel taint\n");
>
> set_bit(flag, &tainted_mask);
> }
> @@ -381,8 +380,7 @@ late_initcall(init_oops_id);
> void print_oops_end_marker(void)
> {
> init_oops_id();
> - printk(KERN_WARNING "---[ end trace %016llx ]---\n",
> - (unsigned long long)oops_id);
> + pr_warn("---[ end trace %016llx ]---\n", (unsigned long long)oops_id);
> }
>
> /*
> _
>


\
 
 \ /
  Last update: 2014-02-14 23:01    [W:0.036 / U:2.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site