| From | Rusty Russell <> | Subject | Re: [PATCH 05/17] lto: Handle LTO common symbols in module loader | Date | Wed, 12 Feb 2014 11:34:12 +1030 |
| |
Andi Kleen <ak@linux.intel.com> writes: > From: Joe Mario <jmario@redhat.com> > > Here is the workaround I made for having the kernel not reject modules > built with -flto. The clean solution would be to get the compiler to not > emit the symbol. Or if it has to emit the symbol, then emit it as > initialized data but put it into a comdat/linkonce section. > > Minor tweaks by AK over Joe's patch.
Patch is fine, but what's with the comment?
> switch (sym[i].st_shndx) { > case SHN_COMMON: > + /* Ignore common symbols */ > + if (!strncmp(name, "__gnu_lto", 9)) > + break; > +
You mean, "/* Ignore symbols from -flto */"?
Other than that, I'm happy for this to go via some other tree:
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks, Rusty.
|