Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver | Date | Thu, 13 Feb 2014 09:51:29 +0900 |
| |
On Wednesday, February 12, 2014 8:00 PM, Pavel Machek wrote: > On Wed 2014-02-05 13:44:58, Jenny Tc wrote: > > On Tue, Feb 04, 2014 at 12:36:30PM +0100, Pavel Machek wrote: > > > > +struct psy_charger_context { > > > > + bool is_usb_cable_evt_reg; > > > > + int psyc_cnt; > > > > + int batt_status; > > > > + /*cache battery and charger properties */ > > > > > > Comment coding style. Please run you patches through checkpatch. > > > > checkpatch doesn't throw any error/warning. /* ... */ not allowed for single line > > comments? (will fix missing space after /*) > > I meant the space after /*. Maybe checkpatch does not report anything > here, but I guess there are other places where it will comment :-).
Yes, right.
+ /*cache battery and charger properties */ ^ 'one space' is necessary between '/*' and 'cache'. This can be fixed as below. + /* cache battery and charger properties */
Best regards, Jingoo Han
| |