[lkml]   [2014]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net 1/3] kref: add kref_sub_return
From: Greg Kroah-Hartman <>
Date: Wed, 12 Feb 2014 08:56:30 -0800

> On Wed, Feb 12, 2014 at 06:38:21PM +0200, Michael S. Tsirkin wrote:
>> It is sometimes useful to get the value of the reference count after
>> decrement.
>> For example, vhost wants to execute some periodic cleanup operations
>> once number of references drops below a specific value, before it
>> reaches zero (for efficiency).
> You should never care about what the value of the kref is, if you are
> using it correctly :)

It isn't being used to determine when to destroy things.

They use it to as a heuristic of when to trigger polling.

Each ubuf attached gets a kref to the higher level virtio_net buffer
holding object, they want to trigger polling when that reference drops
to 1 or lower.

Right now they are reading the atomic refcount directly, which
I think is much worse than this helper.

 \ /
  Last update: 2014-02-13 01:41    [W:0.132 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site