lkml.org 
[lkml]   [2014]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: fix two sparse warnings in early boot string handling
On Wed, 12 Feb 2014, Paul Gortmaker wrote:

> Actually no v2 pending. The original v1 patch was/is correct as-is.
>
> While x86-64 defconfig passed, it turns out that both strcmp and strstr
> have to stay, else we will get this on i386 allyesconfig builds:
>
> arch/x86/boot/compressed/eboot.o: In function `handle_cmdline_files.isra.5.constprop.6':
> eboot.c:(.text+0x4cf): undefined reference to `strstr'
> eboot.c:(.text+0x601): undefined reference to `strstr'
> make[2]: *** [arch/x86/boot/compressed/vmlinux] Error 1
>

This means there is a strstr() prototype that is visible to
drivers/firmware/efi/efi-stub-helper.c but fails at linkage because you've
removed the definition. So, again, why would you add a duplicate
prototype with your patch?

> arch/x86/boot/edd.o: In function `query_edd':
> arch/x86/boot/edd.c:136: undefined reference to `strcmp'
> arch/x86/boot/edd.c:136: undefined reference to `strcmp'
> arch/x86/boot/edd.c:140: undefined reference to `strcmp'
> arch/x86/boot/edd.c:142: undefined reference to `strcmp'
> make[1]: *** [arch/x86/boot/setup.elf] Error 1
>
> So my gut feeling was right after all. ;)
>

I'm not sure what strcmp has to do with this.


\
 
 \ /
  Last update: 2014-02-12 23:41    [W:0.106 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site