Messages in this thread | | | From | Andrew Chew <> | Date | Wed, 12 Feb 2014 13:43:37 -0800 | Subject | RE: [PATCH v5 1/1] watchdog: Add tegra watchdog |
| |
> > +static void tegra_wdt_unref(struct watchdog_device *wdd) { > > + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd); > > + > > + kref_put(&wdt->kref, tegra_wdt_release_resources); } > > I forget why these were needed; they seem to do nothing.
The reason I did the whole kref thing was by following the guidance in Documentation/watchdog/watchdog-kernel-api.txt, which says that if the watchdog_device struct is dynamically allocated, then one needs this.
> > +MODULE_LICENSE("GPL"); > > That should be "GPL v2" according to the license header in the file.
Done. Thanks!
| |