lkml.org 
[lkml]   [2014]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 02/13] pinctrl: mvebu: remove obsolete per-control name buffer allocation
    Date
    With the introduction of a global name buffer, we can now remove
    the allocation and preparation of per-control name buffers.

    Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
    Tested-by: Andrew Lunn <andrew@lunn.ch>
    ---
    Cc: Linus Walleij <linus.walleij@linaro.org>
    Cc: Jason Cooper <jason@lakedaemon.net>
    Cc: Andrew Lunn <andrew@lunn.ch>
    Cc: Gregory Clement <gregory.clement@free-electrons.com>
    Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-kernel@vger.kernel.org
    ---
    drivers/pinctrl/mvebu/pinctrl-mvebu.c | 9 ---------
    1 file changed, 9 deletions(-)

    diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
    index d47650fc5119..c0e27e4f8953 100644
    --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
    +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
    @@ -636,7 +636,6 @@ int mvebu_pinctrl_probe(struct platform_device *pdev)
    pctl->desc.npins = 0;
    for (n = 0; n < soc->ncontrols; n++) {
    struct mvebu_mpp_ctrl *ctrl = &soc->controls[n];
    - char *names;

    pctl->desc.npins += ctrl->npins;
    /* initial control pins */
    @@ -654,14 +653,6 @@ int mvebu_pinctrl_probe(struct platform_device *pdev)
    }

    /* generic mvebu register control */
    - names = devm_kzalloc(&pdev->dev, ctrl->npins * 8, GFP_KERNEL);
    - if (!names) {
    - dev_err(&pdev->dev, "failed to alloc mpp names\n");
    - return -ENOMEM;
    - }
    - for (k = 0; k < ctrl->npins; k++)
    - sprintf(names + 8*k, "mpp%d", ctrl->pid+k);
    - ctrl->name = names;
    pctl->num_groups += ctrl->npins;
    noname += ctrl->npins;
    }
    --
    1.8.5.3


    \
     
     \ /
      Last update: 2014-02-12 19:21    [W:4.042 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site