| Date | Wed, 12 Feb 2014 11:18:37 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 06/35] perf hists: Leave symbol addr hist bucket auto alloc to symbol layer |
| |
Em Wed, Feb 12, 2014 at 06:23:16PM +1100, Anton Blanchard escreveu: > Hi, > > > From: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > Since now symbol__addr_inc_samples() does the auto alloc, no need to > > do it prior to calling hist_entry__inc_addr_samples. > > perf annotate on a ppc64 build (no TUI) is failing. I get zero output. > I haven't had a chance to look closer, but I used the following git > bisect test script to isolate:
Can you try the following patch?
It should fix another problem, i.e. we were allocating, but annotation would fail in the !TUI case, as it would return at symbol__inc_addr_samples when use_browser != 1, now it will allocate and mark the right bucket.
I'll have this in perf/urgent and will do the optimization of not allocating those buckets in the report case when not doing integrated annotation, i.e. report --stdio doesn't provide a way to go to the annotation --stdio, so no point on allocating the buckets. Just on 'annotate --stdio' we should allocate it, etc.
- Arnaldo
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 469eb679fb9d..7cf522523c12 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -489,7 +489,7 @@ static int symbol__inc_addr_samples(struct symbol *sym, struct map *map, { struct annotation *notes; - if (sym == NULL || use_browser != 1 || !sort__has_sym) + if (sym == NULL || !sort__has_sym) return 0; notes = symbol__annotation(sym);
|