Messages in this thread |  | | Date | Wed, 12 Feb 2014 11:11:03 +0000 | From | Mel Gorman <> | Subject | Re: [patch 04/10] mm: shmem: save one radix tree lookup when truncating swapped pages |
| |
On Mon, Feb 03, 2014 at 07:53:36PM -0500, Johannes Weiner wrote: > Page cache radix tree slots are usually stabilized by the page lock, > but shmem's swap cookies have no such thing. Because the overall > truncation loop is lockless, the swap entry is currently confirmed by > a tree lookup and then deleted by another tree lookup under the same > tree lock region. > > Use radix_tree_delete_item() instead, which does the verification and > deletion with only one lookup. This also allows removing the > delete-only special case from shmem_radix_tree_replace(). > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > Reviewed-by: Minchan Kim <minchan@kernel.org> > Reviewed-by: Rik van Riel <riel@redhat.com>
Acked-by: Mel Gorman <mgorman@suse.de>
-- Mel Gorman SUSE Labs
|  |