Messages in this thread | | | Subject | Re: [PATCH v4] ieee80211: Print human-readable disassoc/deauth reason codes | From | Johannes Berg <> | Date | Wed, 12 Feb 2014 11:46:41 +0100 |
| |
On Tue, 2014-02-11 at 12:36 -0600, Calvin Owens wrote: > Create a function to return a descriptive string for each reason code, > and print that in addition to the numeric value in the kernel log. These > codes are easily found on popular search engines, but one is generally > not able to access the internet when dealing with wireless connectivity > issues.
Applied.
> Changes in v2: Refactored array of strings into switch statement. > Changes in v3: Fix style problem, use simplifying macro for switch > statement, eliminate temporary enum variable. > Changes in v4: Move new function to net/mac80211/mlme.c and make it > static, since all of its callers are there.
I removed all this, it belongs after the --- imho.
> + default: return "<INVALID>";
There are many more valid reason codes that this function doesn't understand, so <invalid> is misleading, I replaced that by "<unknown>".
johannes
| |