Messages in this thread |  | | Date | Wed, 12 Feb 2014 11:31:33 +0100 | Subject | Re: [PATCH 06/14] HID: usbhid: change return error of usbhid_output_report | From | David Herrmann <> |
| |
Hi
On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > If there is no urbout when sending a output report, ENOSYS (Function > not implemented) is a better error than EIO (I/O error).
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Thanks David
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/hid/usbhid/hid-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c > index b9a770f..0d1d875 100644 > --- a/drivers/hid/usbhid/hid-core.c > +++ b/drivers/hid/usbhid/hid-core.c > @@ -922,7 +922,7 @@ static int usbhid_output_report(struct hid_device *hid, __u8 *buf, size_t count) > int actual_length, skipped_report_id = 0, ret; > > if (!usbhid->urbout) > - return -EIO; > + return -ENOSYS; > > if (buf[0] == 0x0) { > /* Don't send the Report ID */ > -- > 1.8.3.1 >
|  |