Messages in this thread |  | | Subject | Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node | From | Kumar Gala <> | Date | Tue, 11 Feb 2014 14:28:57 -0600 |
| |
On Feb 10, 2014, at 12:55 PM, Bjorn Andersson <bjorn@kryo.se> wrote:
> On Thu, Feb 6, 2014 at 7:28 AM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote: >> From: "Ivan T. Ivanov" <iivanov@mm-sol.com> >> >> Add the pin control node and pin definitions of SPI8. >> >> Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> >> --- >> arch/arm/boot/dts/qcom-msm8974.dtsi | 29 +++++++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi >> index 9e5dadb..395603f 100644 >> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi >> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi >> @@ -117,5 +117,34 @@ >> clocks = <&gcc GCC_BLSP1_UART2_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>; >> clock-names = "core", "iface"; >> }; >> + >> + msmgpio: pinctrl@fd510000 { >> + compatible = "qcom,msm8974-pinctrl"; >> + reg = <0xfd510000 0x4000>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + interrupts = <0 208 0>; >> + >> + spi8_default: spi8_default { >> + mosi { >> + pins = "gpio45"; >> + function = "blsp_spi8"; >> + }; >> + miso { >> + pins = "gpio46"; >> + function = "blsp_spi8"; >> + }; >> + cs { >> + pins = "gpio47"; >> + function = "blsp_spi8"; >> + }; >> + clk { >> + pins = "gpio48"; >> + function = "blsp_spi8"; >> + }; >> + }; >> + }; >> }; >> }; > > Nice, listing it like this makes it easy to add the electrical > properties when inheriting these nodes, closer to the product dts > files. > > Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Linus,
I can take the .dts patch via the linux-qcom tree to keep it with other DT changes if you want to provide an ack.
- k
-- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
|  |