lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/12] mfd: syscon: Consider platform data a regmap config name
    > Use the device platform data as a regmap config
    > name. This is particularly useful in the regmap
    > debugfs when there is more than one syscon device
    > registered, to distinguish the register blocks.
    >
    > Cc: Samuel Ortiz <sameo@linux.intel.com>
    > Cc: Lee Jones <lee.jones@linaro.org>
    > Signed-off-by: Pawel Moll <pawel.moll@arm.com>
    > ---
    > Alternatively I could define a syscon platform data structure,
    > something like this:
    >
    > struct syscon_platform_data {
    > const char *label;
    > };
    >
    > drivers/mfd/syscon.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
    > index 71841f9..ea1770b 100644
    > --- a/drivers/mfd/syscon.c
    > +++ b/drivers/mfd/syscon.c
    > @@ -143,6 +143,7 @@ static int syscon_probe(struct platform_device *pdev)
    > return -ENOMEM;
    >
    > syscon_regmap_config.max_register = res->end - res->start - 3;
    > + syscon_regmap_config.name = dev_get_platdata(&pdev->dev);

    Perhaps the answer is waiting for me in the other set, but ...

    Isn't this going to be NULL most of the time?

    > syscon->regmap = devm_regmap_init_mmio(dev, base,
    > &syscon_regmap_config);
    > if (IS_ERR(syscon->regmap)) {

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-02-11 19:01    [W:4.624 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site