lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] rcu: Use MAX_NICE to replace hard coding of 19.
On Tue, Feb 11, 2014 at 07:37:32AM -0800, Josh Triplett wrote:
> On Tue, Feb 11, 2014 at 03:34:49PM +0800, Dongsheng Yang wrote:
> > Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> > cc: Josh Triplett <josh@freedesktop.org>
> > cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> > cc: Peter Zijlstra <peterz@infradead.org>
> > cc: Ingo Molnar <mingo@kernel.org>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

I get complaints about MAX_NICE being undefined, and I don't see any
definition of MAX_NICE in sched.h as of 3.14-rc2. Am I looking in
the wrong place, or is this symbol not yet quite in mainline?

Thanx, Paul

> > kernel/rcu/torture.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/kernel/rcu/torture.c b/kernel/rcu/torture.c
> > index 732f8ae..219761d 100644
> > --- a/kernel/rcu/torture.c
> > +++ b/kernel/rcu/torture.c
> > @@ -805,7 +805,7 @@ rcu_torture_writer(void *arg)
> > static DEFINE_RCU_RANDOM(rand);
> >
> > VERBOSE_PRINTK_STRING("rcu_torture_writer task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> >
> > do {
> > schedule_timeout_uninterruptible(1);
> > @@ -871,7 +871,7 @@ rcu_torture_fakewriter(void *arg)
> > DEFINE_RCU_RANDOM(rand);
> >
> > VERBOSE_PRINTK_STRING("rcu_torture_fakewriter task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> >
> > do {
> > schedule_timeout_uninterruptible(1 + rcu_random(&rand)%10);
> > @@ -987,7 +987,7 @@ rcu_torture_reader(void *arg)
> > unsigned long long ts;
> >
> > VERBOSE_PRINTK_STRING("rcu_torture_reader task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> > if (irqreader && cur_ops->irq_capable)
> > setup_timer_on_stack(&t, rcu_torture_timer, 0);
> >
> > @@ -1584,7 +1584,7 @@ static int rcu_torture_barrier_cbs(void *arg)
> >
> > init_rcu_head_on_stack(&rcu);
> > VERBOSE_PRINTK_STRING("rcu_torture_barrier_cbs task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> > do {
> > wait_event(barrier_cbs_wq[myid],
> > (newphase =
> > --
> > 1.8.2.1
> >
>



\
 
 \ /
  Last update: 2014-02-11 18:01    [W:0.063 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site