Messages in this thread | | | From | Laurent Pinchart <> | Subject | Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag | Date | Tue, 11 Feb 2014 13:38:51 +0100 |
| |
Hi Paul,
Thank you for the patch.
On Tuesday 11 February 2014 12:17:01 Paul Bolle wrote: > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > camera interface - Build system") added a Kconfig entry for > VIDEO_OMAP4_DEBUG. But nothing uses that symbol. > > This entry was apparently copied from a similar entry for "OMAP 3 > Camera debug messages". The OMAP 3 entry is used to set the DEBUG > compiler flag, which enables calls of dev_dbg(). > > So add a Makefile line to do that for omap4iss too. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> --- > 0) v1 was called "[media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG". This > versions implements Laurent's alternative (which is much better).
Thanks :-)
> 1) Still untested. > > drivers/staging/media/omap4iss/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/omap4iss/Makefile > b/drivers/staging/media/omap4iss/Makefile index a716ce9..f46c6bd 100644 > --- a/drivers/staging/media/omap4iss/Makefile > +++ b/drivers/staging/media/omap4iss/Makefile > @@ -1,5 +1,7 @@ > # Makefile for OMAP4 ISS driver > > +ccflags-$(CONFIG_VIDEO_OMAP4_DEBUG) += -DDEBUG > + > omap4-iss-objs += \ > iss.o iss_csi2.o iss_csiphy.o iss_ipipeif.o iss_ipipe.o iss_resizer.o > iss_video.o
-- Regards,
Laurent Pinchart
| |