lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] w1: small type cleanup in sysfs
On Tue, Feb 11, 2014 at 10:45:13AM -0600, David Fries wrote:
> Dan,
>
> I have some other changes in work, how automated is your checkers?
> How much work is it for me to give a github repository and branch and
> find out if I introduced any problems before submitting them?
>

This is a Smatch thing I'm working on but haven't pushed yet.
Eventually it will be a part of Fengguang Wu's automated kbuild zero
day testing process.

>
> I didn't get how you could get a less than one after a check for less
> than one from the description or patch until I looked at the rest of
> the source code. Looks good if the description mentions
> max_slave_count is an int.
>
> How about wording it,
>
> On 64 bit systems, a large value for "long tmp" is truncated when
> assigning to "int md->max_slave_count" so we still end up with a value
> less than one despite the "tmp < 1" check.
>

Sure. That's clearer. I have resent it.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-02-13 08:01    [W:0.500 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site