Messages in this thread | | | Date | Mon, 10 Feb 2014 13:32:54 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulator: anatop: Add power gating support to digital LDOs |
| |
On Mon, Feb 10, 2014 at 02:27:55PM +0100, Philipp Zabel wrote:
> yes, thanks. I'll fix this. What should happen if the > regulator_set_voltage_sel_regmap fails? Is it ok to still > set the cache in this case?
Either way is fine but not updating the cache is probably better - if it was a physical write we'd not actually be sure if the write made it to hardware (it could also have written nonsense!) so we can't really guarantee what the state is after a failed operation. [unhandled content-type:application/pgp-signature] | |