lkml.org 
[lkml]   [2014]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH part1 v5 5/7] PCI: Add pci_dummy_ops to isolate pci device temporarily
From
Date
On Mon, 2014-02-10 at 12:04 +0800, Yijing Wang wrote:

> +static DEFINE_SPINLOCK(pci_freeze_lock);

The lock is used only here.

> +/**
> + * pci_bus_freeze_device - freeze pci bus to access pci device
> + * @bus: the pci bus to freeze
> + *
> + * Replace pci bus ops by pci_dummy_ops, protect system from
> + * accessing pci devices.
> + */
> +void pci_bus_freeze_device(struct pci_bus *bus)
> +{
> + struct pci_ops *ops;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&pci_freeze_lock, flags);
> + ops = pci_bus_set_ops(bus, &pci_dummy_ops);
> + bus->save_ops = ops;
> + spin_unlock_irqrestore(&pci_freeze_lock, flags);

Against what exactly are you locking here?

Regards
Oliver




\
 
 \ /
  Last update: 2014-02-10 10:21    [W:0.088 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site