lkml.org 
[lkml]   [2014]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 14/28] Remove MACH_SMDKC210
    From
    Date
    On Mon, 2014-02-10 at 11:41 +0000, Mark Brown wrote:
    > On Sun, Feb 09, 2014 at 07:47:52PM +0100, Richard Weinberger wrote:
    > Please fix whatever script you're using to generate your mails, it's
    > generating corrupt headers.

    I think Richard's mail didn't end up on lkml. But it's pretty clear what
    it must have looked like.

    > > config SND_SOC_SAMSUNG_SMDK_WM9713
    > > tristate "SoC AC97 Audio support for SMDK with WM9713"
    > > - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210)
    > > + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310)
    >
    > Like I said to Paul this isn't fixing the actual issue - think about why
    > the symbol was there in the first place and why it was removed. There
    > is a problem here but this would make it less likely that it would be
    > properly fixed.

    Would you mind going through this one step at a time, just to make sure
    _I_ understand what it is that you'd like to see?

    If so, to be absolutely sure we start from the same point: do you agree
    that the above line now effectively reads
    depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || false || false)

    because there's neither a Kconfig symbol MACH_SMDKV310 nor a Kconfig
    symbol MACH_SMDKC210?


    Paul Bolle



    \
     
     \ /
      Last update: 2014-02-11 01:41    [W:4.041 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site