Messages in this thread | | | Date | Mon, 10 Feb 2014 19:54:21 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: omap-usb-tll: allocate correct size for ch_clk |
| |
> From: Colin Ian King <colin.king@canonical.com> > > ch_clk was erroneously being allocated the incorrect size which > can be problematic for larger sizes of tll->nch > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/mfd/omap-usb-tll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > index 5ee50f7..532eacab 100644 > --- a/drivers/mfd/omap-usb-tll.c > +++ b/drivers/mfd/omap-usb-tll.c > @@ -252,7 +252,7 @@ static int usbtll_omap_probe(struct platform_device *pdev) > break; > } > > - tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]), > + tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk *) * tll->nch, > GFP_KERNEL); > if (!tll->ch_clk) { > ret = -ENOMEM;
Thanks Colin, patch looks good to me.
Roger, fancy finishing this off with an Acked-by?
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |