lkml.org 
[lkml]   [2014]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] MIPS: Octeon: fix fall through on bar type OCTEON_DMA_BAR_TYPE_SMALL
    Date
    From: Colin Ian King <colin.king@canonical.com>

    Bar type OCTEON_DMA_BAR_TYPE_SMALL assigns lo and hi addresses and
    then falls through to OCTEON_DMA_BAR_TYPE_BIG that re-assignes lo and
    hi addresses with totally different values. Add a break so we don't
    fall through.

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: David Daney <ddaney@caviumnetworks.com>
    ---
    arch/mips/pci/msi-octeon.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/mips/pci/msi-octeon.c b/arch/mips/pci/msi-octeon.c
    index d37be36..2b91b0e 100644
    --- a/arch/mips/pci/msi-octeon.c
    +++ b/arch/mips/pci/msi-octeon.c
    @@ -150,6 +150,7 @@ msi_irq_allocated:
    msg.address_lo =
    ((128ul << 20) + CVMX_PCI_MSI_RCV) & 0xffffffff;
    msg.address_hi = ((128ul << 20) + CVMX_PCI_MSI_RCV) >> 32;
    + break;
    case OCTEON_DMA_BAR_TYPE_BIG:
    /* When using big bar, Bar 0 is based at 0 */
    msg.address_lo = (0 + CVMX_PCI_MSI_RCV) & 0xffffffff;
    --
    1.9.rc1


    \
     
     \ /
      Last update: 2014-02-10 20:21    [W:2.234 / U:1.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site