Messages in this thread | | | Date | Mon, 10 Feb 2014 11:53:38 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH] regmap: Check readable regs in _regmap_read |
| |
On 02/10/2014 11:46 AM, Michal Simek wrote: > Check if regs are readable. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/base/regmap/regmap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c > index 6a19515..7569dfc 100644 > --- a/drivers/base/regmap/regmap.c > +++ b/drivers/base/regmap/regmap.c > @@ -1725,6 +1725,9 @@ static int _regmap_read(struct regmap *map, unsigned int reg, > int ret; > void *context = _regmap_map_get_context(map); > > + if (!regmap_readable(map, reg)) > + return -EIO; > +
This will cause issues with devices where registers are writable, but not readable, but we keep the register value in the cache.
> WARN_ON(!map->reg_read); > > if (!map->cache_bypass) { > -- > 1.8.2.3 >
| |