Messages in this thread Patch in this message | | | Date | Mon, 10 Feb 2014 05:28:32 -0800 | From | tip-bot for Peter Zijlstra <> | Subject | [tip:perf/core] perf/x86: Fix Userspace RDPMC switch |
| |
Commit-ID: 0e9f2204cfa6d79abe3e525ddf7c4ab5792cc751 Gitweb: http://git.kernel.org/tip/0e9f2204cfa6d79abe3e525ddf7c4ab5792cc751 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Wed, 5 Feb 2014 11:19:56 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Sun, 9 Feb 2014 13:08:25 +0100
perf/x86: Fix Userspace RDPMC switch
The current code forgets to change the CR4 state on the current CPU. Use on_each_cpu() instead of smp_call_function().
Reported-by: Mark Davies <junk@eslaf.co.uk> Suggested-by: Mark Davies <junk@eslaf.co.uk> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Cc: fweisbec@gmail.com Link: http://lkml.kernel.org/n/tip-69efsat90ibhnd577zy3z9gh@git.kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/kernel/cpu/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c index 1246b85..895604f 100644 --- a/arch/x86/kernel/cpu/perf_event.c +++ b/arch/x86/kernel/cpu/perf_event.c @@ -1826,7 +1826,7 @@ static ssize_t set_attr_rdpmc(struct device *cdev, if (!!val != !!x86_pmu.attr_rdpmc) { x86_pmu.attr_rdpmc = !!val; - smp_call_function(change_rdpmc, (void *)val, 1); + on_each_cpu(change_rdpmc, (void *)val, 1); } return count;
| |