lkml.org 
[lkml]   [2014]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] mfd: MAX6650/6651 support
From
>> +static struct mfd_cell max665x_devs[] = {
>> + { .name = "max6651-gpio", },
>> + { .name = "max6650", }, /* hwmon driver */
>
> What happened to renaming the hwmon driver, so we can have
> "max6650-hwmon" here?

I will add the alias in the next patch (e.g. hwmon change). I can come
back to this and rename then.

>> +static const struct i2c_device_id max665x_id[] = {
>> + { "max6650", TYPE_MAX6650 },
>> + { "max6651", TYPE_MAX6651 },
>> + {},
>
> Can you remind me where these IDs are being used?

Strictly speaking, not in this change, so I can remove it and add
later if needed.

>> +};
>> +MODULE_DEVICE_TABLE(i2c, max665x_id);
>> +
>> +static struct i2c_driver max665x_driver = {
>> + .driver = {
>> + .name = "max665x",
>> + .owner = THIS_MODULE,
>
> All new drivers are required to support Device Tree.

Do you have some recommendation for documentation, examples, etc? I am
new to this.

> <snip>
>
>> +#ifndef __LINUX_MFD_MAX665X_PRIVATE_H
>> +#define __LINUX_MFD_MAX665X_PRIVATE_H
>> +
>> +#include <linux/i2c.h>
>> +#include <linux/export.h>
>
> What's this here for?

Good catch, the export line is a left-over.


\
 
 \ /
  Last update: 2014-02-10 14:41    [W:0.082 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site