Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 1/2 v2] usbnet: fix bad header length bug | Date | Mon, 10 Feb 2014 12:39:07 +0000 |
| |
From: Oliver Neukum > <censored>. Oh well. But how about merging it with FLAG_MULTI_PACKET? > I really don't want to add more flags. There is a point where enough > flags make absurd having a common code. We are closing in on that point.
Any sub-driver that supports multi-packet either has to use stupidly long URB and/or set the rx_urb_size to a multiple of the usb transfer size.
It will also have to detect illegal short headers.
Actually it might be worth double-checking the encapsulations used. IIRC the ax88179_178a uses different headers for tx and rx. So there might be some that support multi-packet but still have a short(ish) limit on the bulk receive size (before the short fragment).
I'm sat at the wrong desk to look at the code...
David
| |