Messages in this thread |  | | Date | Mon, 10 Feb 2014 12:24:11 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 06/14] asmlinkage: Make trace_hardirq visible |
| |
On Sat, Feb 08, 2014 at 08:52:02AM +0100, Andi Kleen wrote: > Can be called from assembler code.
This lacks context; what does __visible do and why does it matter for asm.
> Cc: peterz@infradead.org > Cc: mingo@kernel.org > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > kernel/locking/lockdep.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index c8b6753c..aa3bf15 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -2557,7 +2557,7 @@ static void __trace_hardirqs_on_caller(unsigned long ip) > debug_atomic_inc(hardirqs_on_events); > } > > -void trace_hardirqs_on_caller(unsigned long ip) > +__visible void trace_hardirqs_on_caller(unsigned long ip) > { > time_hardirqs_on(CALLER_ADDR0, ip); > > @@ -2610,7 +2610,7 @@ EXPORT_SYMBOL(trace_hardirqs_on); > /* > * Hardirqs were disabled: > */ > -void trace_hardirqs_off_caller(unsigned long ip) > +__visible void trace_hardirqs_off_caller(unsigned long ip) > { > struct task_struct *curr = current; > > -- > 1.8.5.2 >
|  |