lkml.org 
[lkml]   [2014]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git pull] vfs.git fixes for -rc2
On Mon, Feb 10, 2014 at 09:47:47PM +1100, Dave Chinner wrote:

> and the updated pos value on O_APPEND writes is never folded back
> into ppos.

Not true. Check generic_file_buffered_write() and generic_file_direct_write()
- that's where it's normally stored into iocb->ki_pos (via *ppos). And yes,
I agree that the damn thing is obfuscated to hell and back - other commits
in my local tree kill 'ppos' arguments of __generic_file_aio_write() and
generic_file_buffered_write() (equal to &iocb->ki_pos for all call sites),
which makes it a bit easier to keep track of. Will push that part of
queue into vfs.git#iov_iter today...


\
 
 \ /
  Last update: 2014-02-10 12:41    [W:0.065 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site