Messages in this thread Patch in this message | | | From | Don Zickus <> | Subject | [PATCH 04/21] perf, machine: Use map as success in ip__resolve_ams | Date | Mon, 10 Feb 2014 12:28:59 -0500 |
| |
When trying to map a bunch of instruction addresses to their respective threads, I kept getting a lot of bogus entries [I forget the exact reason as I patched my code months ago].
Looking through ip__resovle_ams, I noticed the check for
if (al.sym)
and realized, most times I have an al.map definition but sometimes an al.sym is undefined. In the cases where al.sym is undefined, the loop keeps going even though a valid al.map exists.
Modify this check to use the more reliable al.map. This fixed my bogus entries.
Signed-off-by: Don Zickus <dzickus@redhat.com> --- tools/perf/util/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index c872991..620a198 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1213,7 +1213,7 @@ static void ip__resolve_ams(struct machine *machine, struct thread *thread, */ thread__find_addr_location(thread, machine, m, MAP__FUNCTION, ip, &al); - if (al.sym) + if (al.map) goto found; } found: -- 1.7.11.7
| |