Messages in this thread | | | Subject | Re: lustre: remove unnecessary 'magic' from lustre_pack_request | From | Oleg Drokin <> | Date | Sat, 1 Feb 2014 13:54:46 -0500 |
| |
Hello!
On Jan 30, 2014, at 12:48 PM, Dave Jones wrote:
> This probably made more sense when the code supported multiple protocol versions, > but now it's just obfuscation. > > Signed-off-by: Dave Jones <davej@fedoraproject.org> > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > index 464479c0f00b..c319f74b04f6 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > @@ -244,15 +244,7 @@ int lustre_pack_request(struct ptlrpc_request *req, __u32 magic, int count, > LASSERT(lens[MSG_PTLRPC_BODY_OFF] == sizeof(struct ptlrpc_body)); > > /* only use new format, we don't need to be compatible with 1.4 */
Can you get rid of this line too please?
> - magic = LUSTRE_MSG_MAGIC_V2;
Bye, Oleg
| |