lkml.org 
[lkml]   [2014]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic
From
Date
Am Donnerstag, den 30.01.2014, 16:10 -0800 schrieb Andi Kleen:
> > @@ -1335,7 +1335,6 @@ config ARCH_SPARSEMEM_ENABLE
> >
> > config ARCH_SPARSEMEM_DEFAULT
> > def_bool y
> > - depends on X86_64
>
> Is that really needed? Why does the vdso need sparsemem?
>

No, it is from the previous patch. I will fix it.

> >
> > static inline void __user *arch_compat_alloc_user_space(long len)
> > {
> > +#ifdef CONFIG_X86_32
> > + struct pt_regs *regs = task_pt_regs(current);
> > + return (void __user *)regs->sp - len;
> > +#else
> > compat_uptr_t sp;
>
> and that? why does a vdso need to allocate things on the user page?
>

Will also fixed, compat.h will not longer include by vsyscall_gtod.c.




\
 
 \ /
  Last update: 2014-02-01 16:41    [W:0.072 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site