Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/2] clk: bcm: kona: don't return -EFOO as bool | Date | Tue, 09 Dec 2014 09:59:42 +0100 |
| |
On Monday 08 December 2014 13:54:04 Olof Johansson wrote: > diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c > index 95af2e6..53fca77 100644 > --- a/drivers/clk/bcm/clk-kona.c > +++ b/drivers/clk/bcm/clk-kona.c > @@ -1252,7 +1252,7 @@ static bool __kona_clk_init(struct kona_clk *bcm_clk) > default: > BUG(); > } > - return -EINVAL; > + return false; > }
Nothing wrong with your patch, but the __kona_clk_init() function is still very strange. Note that the return statement is unreachable, and the reason for the BUG() statement to not be hit is that all kona clocks have type=bcm_clk_peri.
Arnd
| |