Messages in this thread | | | Date | Tue, 9 Dec 2014 08:57:17 +0000 | From | Lee Jones <> | Subject | Re: [alsa-devel][PATCH 1/2] mfd: arizona: Add support for OUTn_MONO register control |
| |
On Mon, 08 Dec 2014, Inha Song wrote:
> Some boards need to set the OUTn_MONO register to configurates > the output signal path as a mono differential output. This > wlf,out-mono property is optional. If present, values must be > specified less than or equal to the number of output signals. > If values less than the number of output signals, elements > that has not been specified are set to 0 by default. > > Example: > - wlf,out-mono = <1 0 1>; /* set OUT1,OUT3 to mono differential */ > > Signed-off-by: Inha Song <ideal.song@samsung.com> > --- > drivers/mfd/arizona-core.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index bce7c07..117be32 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -561,6 +561,16 @@ static int arizona_of_get_core_pdata(struct arizona *arizona) > count++; > } > > + count = 0; > + of_property_for_each_u32(arizona->dev->of_node, "wlf,out-mono", prop, > + cur, val) {
Nit: Can you break after the first parameter instead?
> + if (count == ARRAY_SIZE(arizona->pdata.out_mono))
It's better practise to use ">=".
> + break; > + > + arizona->pdata.out_mono[count] = !!val; > + count++; > + } > + > return 0; > } >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |