Messages in this thread | | | Date | Tue, 9 Dec 2014 15:13:49 -0800 | Subject | Re: [PATCH] PCI: Clear all bridge res MEM_64 if host bridge has non mem64 | From | Yinghai Lu <> |
| |
On Tue, Dec 9, 2014 at 1:53 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Tue, Dec 9, 2014 at 2:34 PM, Yinghai Lu <yinghai@kernel.org> wrote: >> + list_for_each_entry(window, &bridge->windows, list) { >> + res = window->res; >> + if (resource_type(res) == IORESOURCE_MEM || >> + res->end > 0xffffffff) { >> + bridge->has_mem64_res = true; > > This is an interesting idea, but I think you're checking CPU addresses > here, and you need to check PCI bus addresses.
Looks like those IBM platforms have res > 4g, but pci bus address < 4g. If we check pci bus address, and then we would break those platforms.
Yinghai
| |