Messages in this thread | | | Date | Tue, 09 Dec 2014 15:23:25 -0500 (EST) | Subject | Re: [RESEND PATCH] net: introduce helper macra CMSG_FOREACH_HDR | From | David Miller <> |
| |
From: Gu Zheng <guz.fnst@cn.fujitsu.com> Date: Fri, 5 Dec 2014 16:29:07 +0800
> Hi Joe, > Thanks for your comment. > On 12/05/2014 04:02 PM, Joe Perches wrote: > >> On Fri, 2014-12-05 at 15:14 +0800, Gu Zheng wrote: >>> Introduce helper macra >> >> macro > > Ah~, it's a typo. > >> >>> CMSG_FOREACH_HDR as a wrapper of the enumerating >>> cmsghdr from msghdr, just cleanup. >> >> maybe better to use lower case "for_each_cmsg_hdr" >> or some such. > > But this will make it out of the ordinary, as the existed ones > are all upper. > > David, what's your opinion?
I think lowercase looks much better.
| |