Messages in this thread | | | Date | Tue, 9 Dec 2014 13:53:05 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH V5 0/3] perf tool: Haswell LBR call stack support (user) |
| |
On Tue, Dec 09, 2014 at 09:27:08AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 04, 2014 at 04:18:56PM +0000, Liang, Kan escreveu: > > > > > > > > > > On Thu, Dec 04, 2014 at 12:51:42PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Thu, Dec 04, 2014 at 02:49:52PM +0000, Liang, Kan escreveu: > > > > > Jiri Wrote: > > > > > > looks ok to me.. > > > > > > > > > Thanks for the review. > > > > > > > > > > I'll test it once I get hands on Haswel server again, I guess we > > > > > > wait for the kernel change to go in first anyway, right? > > > > > > > > > I'm not sure, let's ask Peter. > > > > > > > > > Peter? > > > > > > > > Would be good to go in one pull request, so that whoever pulls it has > > > > the chance to test the kernel feature with the accompanying tooling bits. > > > > > > also there's user part dependency on kernel.. soem new define IIRC > > > > > > > Oh, right. We have to let them go in together. > > > > Hi Peter, > > The ones that are just prep patches I am merging now, Jiri, can I stick > an Acked-by to the non-LBR related ones?
I guess u mean just this one? 2803 T Dec 02 kan.liang@intel (3.4K) ├─>[PATCH V5 2/3] perf tool: Move cpumode resolve code to add_callchain_ip
yep, ack
jirka
> > > I have verified that the V8 kernel part patch is compatible with both latest > > tip and latest perf/core. We don't need to rebase. > > The user perf tool for tip is not updated yet. We need to merge latest > > perf/core to tip before applying user part patch. > > > > Do you have more comments for the code? > > > > The latest kernel and user part codes are here. > > https://lkml.org/lkml/2014/11/6/432 > > https://lkml.org/lkml/2014/12/2/396 > > > > Thanks, > > Kan
| |