Messages in this thread | | | Date | Tue, 9 Dec 2014 11:14:16 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/8] perf tools: Add feature check for libbabeltrace |
| |
On Mon, Dec 08, 2014 at 05:07:23PM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Thu, Dec 4, 2014 at 1:23 AM, Jiri Olsa <jolsa@kernel.org> wrote: > > +ifndef NO_LIBBABELTRACE > > + # for linking with debug library, run like: > > + # make DEBUG=1 LIBBABELTRACE_DIR=/opt/libdw/ > > s/libdw/libbabeltrace/
ouch.. copy&paste crap ;-)
> > > > + ifdef LIBBABELTRACE_DIR > > + LIBBABELTRACE_CFLAGS := -I$(LIBBABELTRACE_DIR)/include > > + LIBBABELTRACE_LDFLAGS := -L$(LIBBABELTRACE_DIR)/lib > > + endif > > + FEATURE_CHECK_CFLAGS-libbabeltrace := $(LIBBABELTRACE_CFLAGS) > > + FEATURE_CHECK_LDFLAGS-libbabeltrace := $(LIBBABELTRACE_LDFLAGS) -lbabeltrace-ctf > > +endif > > + > > # include ARCH specific config > > -include $(src-perf)/arch/$(ARCH)/Makefile > > > > @@ -201,6 +212,7 @@ CORE_FEATURE_TESTS = \ > > stackprotector-all \ > > timerfd \ > > libdw-dwarf-unwind \ > > + libbabeltrace \ > > zlib > > > > LIB_FEATURE_TESTS = \ > > @@ -216,6 +228,7 @@ LIB_FEATURE_TESTS = \ > > libslang \ > > libunwind \ > > libdw-dwarf-unwind \ > > + libbabeltrace \ > > zlib > > > > VF_FEATURE_TESTS = \ > > @@ -661,6 +674,17 @@ else > > NO_PERF_READ_VDSOX32 := 1 > > endif > > > > +ifndef NO_LIBBABELTRACE > > + ifeq ($(feature-libbabeltrace), 0) > > + msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-devel/libbabeltrace-dev); > > It seems that Ubuntu has libbabeltrace-ctf-dev package.
ok
thanks, jirka
| |