Messages in this thread | | | Date | Mon, 8 Dec 2014 08:14:39 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v2] Drivers: memstick: host: Fixed missing a blank line warning |
| |
Not a bad attempt.
The subject line should match the subsystem. You can see what that is by issuing `git log --oneline -- drivers/memstick/` (supplement drivers/memstick for the subsystem that you're submitting to).
> Added a new line after declaration to fix the warning message > 'Missing a blank line after declarations' > > Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com> > --- > drivers/memstick/host/rtsx_usb_ms.c | 1 + > 1 file changed, 1 insertion(+)
Apart from my comment at the top (which a kind maintainer can fix for you on this occasion I'm sure ;) ), the patch looks good:
Acked-by: Lee Jones <lee.jones@linaro.org>
Now make 3 such changes (you can use checkpatch on some other files) and send them as a patch-set.
> diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c > index a7282b7..cefd745 100644 > --- a/drivers/memstick/host/rtsx_usb_ms.c > +++ b/drivers/memstick/host/rtsx_usb_ms.c > @@ -59,6 +59,7 @@ static inline struct device *ms_dev(struct rtsx_usb_ms *host) > static inline void ms_clear_error(struct rtsx_usb_ms *host) > { > struct rtsx_ucr *ucr = host->ucr; > + > rtsx_usb_ep0_write_register(ucr, CARD_STOP, > MS_STOP | MS_CLR_ERR, > MS_STOP | MS_CLR_ERR);
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |