Messages in this thread | | | From | Alexandre Courbot <> | Date | Tue, 9 Dec 2014 12:06:10 +0900 | Subject | Re: [PATCH] gpio: bcm-kona: memory corruption fix |
| |
On Tue, Dec 9, 2014 at 6:34 AM, Olof Johansson <olof@lixom.net> wrote: > In one instance the base address of the internal controller state > structure is passed into a function doing writel to an offset of > the pointer passed in is used, instead of the register base. > > Once I found the bug, I also went back to check for other sparse > warnings in the file, but found none. This one, however, triggered: > > drivers/gpio/gpio-bcm-kona.c:552:47: warning: incorrect type in argument 1 (different address spaces) > drivers/gpio/gpio-bcm-kona.c:552:47: expected void [noderef] <asn:2>*reg_base > drivers/gpio/gpio-bcm-kona.c:552:47: got struct bcm_kona_gpio *kona_gpio > drivers/gpio/gpio-bcm-kona.c:556:47: warning: incorrect type in argument 1 (different address spaces) > drivers/gpio/gpio-bcm-kona.c:556:47: expected void [noderef] <asn:2>*reg_base > drivers/gpio/gpio-bcm-kona.c:556:47: got struct bcm_kona_gpio *kona_gpio > > As far as I can tell, this bug has been here for a long time and is > not new, but I found it when hunting down another heisenbug on this > platform.
Ouch. Thanks for fixing this.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
| |