Messages in this thread | | | Subject | Re: [PATCH] staging: ion: ion_cma_heap: remove ion_cma_get_sgtable | From | Joe Perches <> | Date | Mon, 08 Dec 2014 17:29:18 -0800 |
| |
On Tue, 2014-12-09 at 09:19 +0800, Zeng Tao wrote: > Remove the temporary code ion_cma_get_sgtable, > use dma_common_get_sgtable instead [] > diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c [] > @@ -91,7 +73,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, > if (!info->table) > goto free_mem; > > - if (ion_cma_get_sgtable > + if (dma_common_get_sgtable > (dev, info->table, info->cpu_addr, info->handle, len)) > goto free_table; > /* keep this for memory release */
somewhat unrelated trivia:
It'd conform a bit more to kernel style to write this with at least one argument on the same line as the function like:
if (dma_common_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len)) goto free_table;
| |