Messages in this thread | | | Date | Mon, 08 Dec 2014 14:07:07 +0100 | From | Richard Weinberger <> | Subject | Re: [PATCH 3/6] UBI: Fastmap: Notify user in case of an ubi_update_fastmap() failure |
| |
Am 08.12.2014 um 14:00 schrieb Tanya Brokhman: >>>> Maybe the case you've described is powercut safe, but there can be other unsafe cases. >>>> Let's stay on the safe side and be paranoid, it does not hurt. >>>> If fastmap has proven stable we can start with tricky optimizations. >>> >>> I'm sorry that I'm being petty here but the commit msg states that you "notify the user in case of update fastamap failure". It says nothing about you failing ubi_wl_get_peb as >>> well. And this is a major change. At least divide this into 2 patches (so I can disagree to the function failing and agree to the msg to user :) ) >> >> With user I meant users of that function. > > I still don't like it. > Leaving this one for Artem... sorry
As I said, as soon we all consider fastmap mature and stable we can start with optimizations. But as of now I want all logic to be on the safe side. This is how all fastmap code is designed.
Thanks, //richard
| |